Various minore fixes in the amdgpu plugin #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It means CRIU has to close it when it is not needed. It looks more logically correct and matches the behaviour of the RESTORE_EXT_FILE callback. Signed-off-by: Andrei Vagin <[email protected]>
avagin
force-pushed
the
amdgpu-fixes
branch
from
2a56b5e to
8f92bd5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## criu-dev #2274 +/- ##
============================================
- Coverage 70.52% 70.51% -0.02%
============================================
Files 132 132
Lines 33508 33508
============================================
- Hits 23632 23628 -4
- Misses 9876 9880 +4
☔ View full report in Codecov by Sentry. |
rst0git
reviewed
Sep 29, 2023
dayatsin-amd
approved these changes
Sep 29, 2023
dayatsin-amd
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
All 3 patches look good to me.
@fdavid-amd Can you test these patches
Signed-off-by: Andrei Vagin <[email protected]>
avagin
force-pushed
the
amdgpu-fixes
branch
from
8f92bd5 to
4d24584
Compare
rst0git
reviewed
Sep 30, 2023
|
I tested these changes locally with AMD MI100, and I can confirm that the checkpoint/restore works as expected. |
Signed-off-by: Andrei Vagin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.